recently came across protobuf-net, awesome library.
i ran through gendarme , came many performance notifications, e.g:
target: system.int32 protobuf.protoreader::readfieldheader() assembly: protobuf-net, version=1.0.0.0, culture=neutral, publickeytoken=null
severity: high confidence: high source: debugging symbols unavailable, il offset 0x0055 details: type 'system.int32' being boxed.
if has experience gendarme how important these sort of notifications , possibly contribute protobuf-net attempting clean severity: high issues?
the specific error cite comes from:
if(fieldnumber < 1) throw new protoexception( "invalid field in source data: " + fieldnumber); so, yes technically unnecessary box - however, extreme edge case not worth caring (if exception, have bigger problems box). fixed if causing concern, though.
it further errors being raised reflection implementation - misleading because in scenarios isn't used (the code has both reflection model , meta-programming model).
i aim have @ gendarme says next week: update - done - note of "busy work" - didn't change important, other made gendarme happy.
Comments
Post a Comment