how simplify these lines. have hundreds of these lines setting value in each table cell.
dailyresult("select count(*) fault type = 'e-mail fault' , no_fault_number <> 'no fault number' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 77, 1); dailyresult("select count(*) fault type = 'e-mail fault' , no_fault_number = 'no fault number' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 78, 1); dailyresult("select count(*) fault cmts = 'sj1' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 80, 1); dailyresult("select count(*) fault cmts = 'sj2' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 81, 1); dailyresult("select count(*) fault cmts = 'sj3' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 82, 1); dailyresult("select count(*) fault cmts = 'ala1' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 83, 1); dailyresult("select count(*) fault cmts = 'ala2' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 84, 1); dailyresult("select count(*) fault cmts = 'fvw' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 85, 1); dailyresult("select count(*) fault cmts = 'mnd1' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 86, 1); dailyresult("select count(*) fault call_concern = 'slow connection' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 88, 1); dailyresult("select count(*) fault call_concern = 'no connection' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 89, 1); dailyresult("select count(*) fault call_concern = 'intermittent connection' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 90, 1); just looking @ makes me feel terrible , need find out there loop simplify this? type of great.
here method code btw.
public void dailyresult(string q, int x, int y){ try{ statement stmtdr = (statement)daily.createstatement(); resultset rs = stmtdr.executequery(q); if(rs.next()){ reporttable1.setvalueat(rs.getint(1), x, y); } }catch(exception e){ joptionpane.showmessagedialog(rootpane, "error 106\n\nan error has occured resultset procedure method. please try again later.", "error!", joptionpane.error_message);
you use group in queries, replace this
dailyresult("select count(*) fault cmts = 'mnd1' , calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year , 86, 1); with
dailyresult("select cmts,count(*) fault calltypeint = 'tri' , dc_month = " + month + " , dc_day = " + day + " , dc_year = " + year +" group cmts", 86, 1); then in dailyresult
resultset rs = stmtdr.executequery(q); while(rs.next()){ // expecting multiple rows string faulttype = rs.getstring(1);//what fault this? reporttable1.setvalueat(rs.getint(2), getxoffset(faulttype), y); } something careful of if no faults found no row returned same behaviour have now, assume catering that.
Comments
Post a Comment